Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum instead of strings + fix status gets stucked issue #1426

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented May 11, 2019

In the StatusBar, for statuses, it'd be better to use enum instead of strings and the converter.

I also added a lock to the animation, which fixes an annoying bug, where the Loading... got stuck often.

nopara73 added some commits May 11, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented May 11, 2019

Note, while it seems like a lot of code, these were straightforward changes.

@@ -11,6 +11,7 @@
<converters:ShowCursorConverter x:Key="ShowCursorConverter" />
<converters:ShouldDisplayValueConverter x:Key="ShouldDisplayValueConverter" />
<converters:PascalToPhraseConverter x:Key="PascalToPhraseConverter" />
<converters:StatusBarStatusStringConverter x:Key="StatusBarStatusStringConverter" />

This comment has been minimized.

Copy link
@nopara73

nopara73 May 11, 2019

Author Collaborator

I left this in, in case we need this in the future.

@nopara73 nopara73 requested review from molnard and danwalmsley and removed request for molnard May 11, 2019

@nopara73 nopara73 merged commit 9a6abe5 into zkSNACKs:master May 14, 2019

1 of 3 checks passed

Wasabi.Linux queued
Details
Wasabi.Osx queued
Details
CodeFactor No issues found.
Details

@nopara73 nopara73 deleted the nopara73:enum branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.