Bugfix: Fix focus on NoparaPasswordBox that selects text instead of navigating to next field #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the bug is actually a hack around a larger bug, but I'm not sure @molnard created it, so it's up to him to review. |
molnard
approved these changes
May 27, 2019
|
Solves the issue. Can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1430.
Background: The small button that is used to show the password is focusable but when it gets the focus for some reason the whole text is selected.
Quick fix is to not give the "Show password" button the focus.
If this button should be usable when navigating the forms with the keyboard, then a more elaborate fix needs to be implemented.