Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix focus on NoparaPasswordBox that selects text instead of navigating to next field #1463

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
3 participants
@guggero
Copy link
Contributor

commented May 23, 2019

Fixes #1430.

Background: The small button that is used to show the password is focusable but when it gets the focus for some reason the whole text is selected.
Quick fix is to not give the "Show password" button the focus.
If this button should be usable when navigating the forms with the keyboard, then a more elaborate fix needs to be implemented.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented May 24, 2019

I think the bug is actually a hack around a larger bug, but I'm not sure @molnard created it, so it's up to him to review.

@nopara73 nopara73 requested a review from molnard May 24, 2019

@molnard

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Solves the issue. Can be merged.

@nopara73 nopara73 merged commit 776d68c into zkSNACKs:master May 28, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190523.4 succeeded
Details
Wasabi.Osx #20190523.4 succeeded
Details
Wasabi.Windows #20190523.4 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.