Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DustThreshold configurable. #1464

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
2 participants
@nopara73
Copy link
Collaborator

commented May 24, 2019

@lontivero's PR (#1384) enabled us to make the DustThreshold configurable.

This is a straightforward PR.

@nopara73 nopara73 requested a review from lontivero May 24, 2019

@nopara73 nopara73 added this to In Progress in v1.1.5 via automation May 24, 2019

@@ -72,7 +72,5 @@ public static BitcoinWitPubKeyAddress GetCoordinatorAddress(Network network)

public const string ChangeOfSpecialLabelStart = "change of (";
public const string ChangeOfSpecialLabelEnd = ")";

public static Money DustThreshold = Money.Coins(0.0001m);

This comment has been minimized.

Copy link
@lontivero

lontivero May 24, 2019

Contributor

I think it is a good thing to have this constant here in order to avoid repeating the 0.0001m in other places. The only thing I would do is to rename it as DefaultDustThreshold instead of DustThreshold here and then use it everywhere.

This comment has been minimized.

Copy link
@nopara73

nopara73 May 24, 2019

Author Collaborator

What do you mean? If you add a constant here then it's dangerous that someone else would start using it from here and not from the configured one.

This comment has been minimized.

Copy link
@lontivero

lontivero May 24, 2019

Contributor

The code can not prevent developers do something wrong. To prevent such things we have communication and code reviews (we are not a 30 members team). Anyway, it is a suggestion.

@lontivero
Copy link
Contributor

left a comment

It is good, I have only one comment for your consideration.

@nopara73 nopara73 merged commit d23e1ff into zkSNACKs:master May 24, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190524.8 succeeded
Details
Wasabi.Osx #20190524.8 succeeded
Details
Wasabi.Windows #20190524.8 succeeded
Details

v1.1.5 automation moved this from In Progress to Done May 24, 2019

@nopara73 nopara73 deleted the nopara73:dustconfig branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.