Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when exception at disposing #1467

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented May 24, 2019

No description provided.

@nopara73 nopara73 requested a review from lontivero May 24, 2019

@@ -41,6 +42,10 @@ private static async Task TryRemoveWorkingDirectoryAsync()
catch (DirectoryNotFoundException)
{
}
catch (Exception ex)

This comment has been minimized.

Copy link
@lontivero

lontivero May 24, 2019

Contributor

It looks okay to me. What seems wrong is that there is an empty catch(DirectoryNotFoundException) two lines above when the invoked method closed in the try block cannot throw that exception.

This comment has been minimized.

Copy link
@nopara73

nopara73 May 24, 2019

Author Collaborator

That empty trycatch came from copypasting NBitcoin. The exception I get sometimes is an unauthorized exception to the .lock. Nevertheless Dispose should not throw.

@nopara73 nopara73 merged commit 634d908 into zkSNACKs:master May 24, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190524.12 succeeded
Details
Wasabi.Osx #20190524.12 succeeded
Details
Wasabi.Windows #20190524.12 succeeded
Details

@nopara73 nopara73 deleted the nopara73:logex branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.