Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open wallet file with double click #1512

Merged

Conversation

Projects
None yet
5 participants
@lontivero
Copy link
Collaborator

commented May 30, 2019

Close #1477

@molnard
Copy link
Collaborator

left a comment

Works fine, one code style suggestion. Can be merged after that.

@lontivero lontivero force-pushed the lontivero:Features/Open-Wallet-With-Double-Click branch from acaeba4 to 3d8b99d May 30, 2019

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented May 30, 2019

Done. I've squashed the commits (forced the push)

@molnard

This comment has been minimized.

Copy link
Collaborator

commented May 31, 2019

Works fine, can be merged.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented May 31, 2019

@danwalmsley Can you review this?

@nopara73 nopara73 requested a review from danwalmsley May 31, 2019

@lontivero lontivero force-pushed the lontivero:Features/Open-Wallet-With-Double-Click branch from 5d76a2e to 90f34a4 Jun 1, 2019

@danwalmsley

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

@danwalmsley Can you review this?

ACK

@danwalmsley
Copy link
Contributor

left a comment

Small change requested, but looks perfect otherwise.

@danwalmsley
Copy link
Contributor

left a comment

Great :)

@molnard

molnard approved these changes Jun 3, 2019

@nopara73 nopara73 merged commit 5efd1c6 into zkSNACKs:master Jun 4, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190602.2 succeeded
Details
Wasabi.Osx #20190602.2 succeeded
Details
Wasabi.Windows #20190602.2 succeeded
Details

@lontivero lontivero deleted the lontivero:Features/Open-Wallet-With-Double-Click branch Jun 15, 2019

@MaxHillebrand

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

Works perfect on Debian, @nopara73 the response area is large enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.