Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick seemingly uncontroversial commits from https://github.com/zkSNACKs/WalletWasabi/pull/1361 #1521

Merged
merged 4 commits into from Jun 3, 2019

Conversation

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented Jun 1, 2019

No description provided.

danwalmsley and others added some commits May 31, 2019

@nopara73 nopara73 requested review from danwalmsley and molnard and removed request for molnard Jun 1, 2019

@danwalmsley
Copy link
Contributor

left a comment

Looks good. going forward all xaml files should define x:Class which is what most of the xaml compile changes are.

@nopara73 nopara73 merged commit 74787a6 into zkSNACKs:master Jun 3, 2019

3 of 4 checks passed

Wasabi.Osx #20190601.6 failed
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190601.6 succeeded
Details
Wasabi.Windows #20190601.6 succeeded
Details

@nopara73 nopara73 deleted the nopara73:xaml branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.