Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolate warning removal from console. #1531

Merged
merged 4 commits into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@molnard
Copy link
Collaborator

commented Jun 3, 2019

I got this on console.

PS C:\WORK\WalletWasabi\WalletWasabi.Gui> dotnet run
KeyManagement\HdPubKey.cs(111,67): warning CS0618: 'PubKey.GetAddress(Network)' is obsolete: 'Use GetAddress(ScriptPubKeyType.Legacy, network) instead' [C:\WORK\WalletWasabi\WalletWasabi\WalletWasabi.csproj]
2019-06-03 14:42:47 INFO 3b5e1cd5-edad-4fc3-8df1-f46766993b18: Wasabi GUI is starting...
2019-06-03 14:42:50 INFO Config: Config is successfully initialized.

Function only used in tests, runs fine after the fix.

@molnard molnard changed the title Use new instead of obsolate. Obsolate warning removal from console. Jun 3, 2019

molnard and others added some commits Jun 3, 2019

Update WalletWasabi/KeyManagement/HdPubKey.cs
Co-Authored-By: Lucas Ontivero <lontivero@users.noreply.github.com>

@nopara73 nopara73 merged commit 85c7816 into zkSNACKs:master Jun 4, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190603.8 succeeded
Details
Wasabi.Osx #20190603.8 succeeded
Details
Wasabi.Windows #20190603.8 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.