Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Log message on console when --version #1532

Merged
merged 2 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@molnard
Copy link
Collaborator

commented Jun 3, 2019

fixes: #1519

We have Logger.TurnOff() which completely disable logging. Instead of that I prefer checking if there any mutex to release and if not then there is no log message on console.
Why?

  1. I want to keep the logging system on in any case of error there.
  2. At Global.DisposeAsync() we are doing the same with Managers so better do something similar -> Only execute dispose/close/release if required else no Log message.
@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

ACK (with the small syntax sugar.)

@nopara73 nopara73 merged commit a3105a8 into zkSNACKs:master Jun 4, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190604.6 succeeded
Details
Wasabi.Osx #20190604.6 succeeded
Details
Wasabi.Windows #20190604.6 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.