Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more parameters to the settings page #1538

Merged
merged 10 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@lontivero
Copy link
Collaborator

commented Jun 4, 2019

This PR allows the user to modify the following settings:

  • SomePrivacyLevel,
  • FinePrivacyLevel,
  • StrongPrivacyLevel and,
  • DustThreshold.
@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

Concept ACK. Is it review ready?

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 5, 2019

Yes, I think it is ready for review.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

UX Reveiw

Wouldn't it be better to use the shields instead of the "Some/Fine...)?

image

lontivero and others added some commits Jun 6, 2019

Improve Labels
Co-Authored-By: nopara73 <adam.ficsor73@gmail.com>
@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

Done.

image

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

UI getting closer, but still doesn't feel right. Let me mess around here.

nopara73 added some commits Jun 11, 2019

@nopara73 nopara73 merged commit 2b78d87 into zkSNACKs:master Jun 11, 2019

2 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
Wasabi.Osx #20190611.8 succeeded
Details

@lontivero lontivero deleted the lontivero:Features/More-Config-UI branch Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.