Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume Shell via Stable Release Nuget Package - Remove Submodule #1544

Conversation

Projects
None yet
3 participants
@danwalmsley
Copy link
Contributor

commented Jun 6, 2019

No description provided.

Show resolved Hide resolved Directory.Build.props Outdated
Show resolved Hide resolved WalletWasabi.sln Outdated
{
throw new FormatException("font is missing fallback to default font");
}
FontFamily = FontFamily.Parse(fontName); // Use the font.

This comment has been minimized.

Copy link
@nopara73

nopara73 added some commits Jun 7, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Reviewed. After the FontFamily stuff is discussed I merge. I tested giving out a release, too, it works fine on Windows.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

@molnard How do you like this? 8ea5a8f

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Resolved the issues for now. Waiting for your test @molnard

@molnard

molnard approved these changes Jun 7, 2019

@nopara73 nopara73 merged commit a01cb34 into zkSNACKs:master Jun 7, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190607.7 succeeded
Details
Wasabi.Osx #20190607.7 succeeded
Details
Wasabi.Windows #20190607.7 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.