Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more client side checks #1547

Merged
merged 1 commit into from Jun 16, 2019

Conversation

Projects
None yet
3 participants
@nopara73
Copy link
Collaborator

commented Jun 9, 2019

Closes #1379

The quickfix suggested by @NicolasDorier for issue #1379 to upper cap the peer limit and check that on the client side.

Such client side limitations can be problematic in the future and it's clear this is not the best way to go about it, yet I wonder if there're any downsides doing this anyway. We won't be able to go over 100 peers like ever. There are just so many practical issues (IsStandard, Tor, too-long-mempool-chain) with this.

Note I did 110 instead of 100 to give some wiggle room.

@NicolasDorier

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

Seems to work.

@nopara73 nopara73 changed the title [Discussion] Upper cap client anonset limit. Upper cap client anonset limit. Jun 11, 2019

@nopara73 nopara73 changed the title Upper cap client anonset limit. Add more client side checks Jun 11, 2019

@nopara73 nopara73 marked this pull request as ready for review Jun 16, 2019

@nopara73 nopara73 merged commit 8201c87 into zkSNACKs:master Jun 16, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190609.1 succeeded
Details
Wasabi.Osx #20190609.1 succeeded
Details
Wasabi.Windows #20190609.1 succeeded
Details

@nopara73 nopara73 deleted the nopara73:uppercap branch Jun 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.