Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reliance on "ZeroLink" special label #1549

Merged
merged 4 commits into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented Jun 10, 2019

Checking the "ZeroLink" special label is not only a code smell, but it actually enables Attack 1 (Remix Attacks), that Udi described in his presentation on Breaking Bitcoin. https://www.youtube.com/watch?v=DqhxPWsJFZE

This change removes the label reliance and tries to check if the new coin that arrived spends a coin that is already enqueued instead.

@nopara73 nopara73 requested a review from lontivero Jun 10, 2019

@lontivero
Copy link
Collaborator

left a comment

It is okay. Only one minor comment.

nopara73 added some commits Jun 10, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

@lontivero I made a bit more improvement. Please review again.

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 10, 2019

This also introduces a code smell, since we're enqueueing with Task.Run(async () => asynchronously. I'll make a different PR on top of this PR to fix that, but that's a bit dangerous, so I won't include it here.

@nopara73 nopara73 referenced this pull request Jun 10, 2019

Merged

Remove Task.Run #1550

@lontivero
Copy link
Collaborator

left a comment

It is okay.

@nopara73 nopara73 merged commit a082c3f into zkSNACKs:master Jun 10, 2019

1 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Osx in progress
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details

@nopara73 nopara73 deleted the nopara73:nolabel branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.