Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Task.Run #1550

Merged
merged 3 commits into from Jun 12, 2019

Conversation

Projects
None yet
4 participants
@nopara73
Copy link
Collaborator

commented Jun 10, 2019

PR #1549 introduces a code smell, because now we shouldn't run enqueue asynchronously, but in order to await it we need to make the functions above it async, too.

@nopara73 nopara73 requested review from lontivero and molnard Jun 10, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 11, 2019

@Rmartin1104 can you run this through the testing document?

@Rmartin1104

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Operating System: Windows 10

  • pass Wasabi GUI exit test
  • pass Filter downloading tests

nopara73 added some commits Jun 11, 2019

@molnard
Copy link
Collaborator

left a comment

Tested CJ for hours works fine.

@nopara73 nopara73 merged commit 3811015 into zkSNACKs:master Jun 12, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190611.15 succeeded
Details
Wasabi.Osx #20190611.15 succeeded
Details
Wasabi.Windows #20190611.15 succeeded
Details

@nopara73 nopara73 deleted the nopara73:removetaskrun branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.