Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the sum of selected coins' amount #1565

Merged
merged 3 commits into from Jun 15, 2019

Conversation

Projects
None yet
2 participants
@lontivero
Copy link
Collaborator

commented Jun 13, 2019

Closes #1561
Closes #1262

The sum of the selected coins is displayed next to the selection checkboxes.

image

Related #1561 #1262 #1369

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 13, 2019

I forgot to mention that this is for concept discussion only. It is not ready for merging because it doesn't take Lurking Wife mode into account, for example.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

Yes, this is great and also looks great!

  • Add LWF
  • Maybe make the whole thing only visible if a coin is selected.
@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 13, 2019

Done.

@nopara73 nopara73 merged commit 6c0b502 into zkSNACKs:master Jun 15, 2019

3 of 4 checks passed

Wasabi.Osx #20190613.5 failed
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190613.5 succeeded
Details
Wasabi.Windows #20190613.5 succeeded
Details

@lontivero lontivero deleted the lontivero:Features/Sum-Selected-Coins branch Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.