Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle filters to update less often. #1572

Merged
merged 1 commit into from Jun 16, 2019

Conversation

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented Jun 16, 2019

Fixes #1571

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 16, 2019

I'm merging this without review, because it's a critical bugfix. Without this Wasabi is randomly crashing. But feel free to start a discussion on it.

@nopara73 nopara73 merged commit 046035b into zkSNACKs:master Jun 16, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190616.2 succeeded
Details
Wasabi.Osx #20190616.2 succeeded
Details
Wasabi.Windows #20190616.2 succeeded
Details

@nopara73 nopara73 deleted the nopara73:throttle branch Jun 16, 2019

@NicolasDorier

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

I can understand why this fix the freeze on the UI, but I can't explain why this fix the stack overflow issue.

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 17, 2019

I can understand why this fix the freeze on the UI, but I can't explain why this fix the stack overflow issue.

RX has some magic going on. On my computer this fixes the stackoverflow without a doubt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.