Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IDE/Editor folders and files #1581

Merged
merged 1 commit into from Jun 18, 2019

Conversation

Projects
None yet
3 participants
@benthecarman
Copy link
Contributor

commented Jun 17, 2019

There isn't a real reason for a .vscode folder or a .editorconfig to be in the repo. If you want these to be excluded from something like git add -A then you can follow this guide to exclude desired files/folders.

@benthecarman benthecarman force-pushed the benthecarman:remove_vs_code branch from 1286dbe to de26369 Jun 17, 2019

@benthecarman benthecarman changed the title remove .vscode IDE folder Remove IDE/Editor folders and files Jun 17, 2019

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jun 17, 2019

ACK. There is no reason for having .vscode folder.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2019

.editorconfig is needed. @lontivero Are you sure about .settings.json?

This looks reasonable, but not exactly sure what it does:

{	
	"editor.detectIndentation": false,	
	"editor.insertSpaces": false	
}

Maybe we should improve it instead of removing it. I suspect .vscode doesn't pick up on .editorconfig, right?

@benthecarman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

I don't think either are needed, they are both just IDE config files. These should just be saved locally and don't have anything to do with running/building Wasabi

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2019

.editorconfig is needed to enforce coding style. I would love if it'd work on vscode, too. In fact, @lontivero can you take a look at this? https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig

@benthecarman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

If you want to keep the .editorconfig to enforce coding style, then https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig looks like a good idea and we could remove the .vscode folder then.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2019

.editorconfig is required, what can be removed is the .vscode folder because it was added because some random guy wanted to make my life miserable but we already reverted that change and the folder shouldn't be uploaded.

@benthecarman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

Okay I'll undo the commit that removes .editorconfig

@benthecarman benthecarman force-pushed the benthecarman:remove_vs_code branch from de26369 to 1e004f6 Jun 18, 2019

@nopara73 nopara73 merged commit 34d1fad into zkSNACKs:master Jun 18, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190618.13 succeeded
Details
Wasabi.Osx #20190618.13 succeeded
Details
Wasabi.Windows #20190618.13 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:remove_vs_code branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.