Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1: Remove Global.Instance singleton #1592

Merged
merged 12 commits into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@NicolasDorier
Copy link
Contributor

commented Jun 19, 2019

I extracted the most difficult part of #1591 in this PR which is easy to review and obviously right.

NicolasDorier and others added some commits Jun 19, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

I moved out your AvaloniaExtensions from the Extensions folder to a new Helpers folder. I usually put these there, but Extensions is a special folder in Avalonia.Shell (thus the DummyHack inside.)

This is where the Avalonia.Shell extensions would go. It's like Visual Studio extensions, anyone should be able to add extensions to Wasabi. While we don't use it, the shell fails if that folder is not present and it cannot be created runtime, because Wasabi runs without administration privileges, and when Wasabi gets into the Program Files folder, it cannot write anything next to it. (Thus the DummyHack.)

(My review is not finished yet.)

nopara73 added some commits Jun 19, 2019

@NicolasDorier

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

Please don't Use GetOrCreate. I need it for the followup PR, else I can't pass the Global instance to the tab.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

But then if there's no WalletManager initialized yet those menu items would fail. And this will happen when we implement @dennisreimann's suggestion for a welcome screen: #1369 (comment)

image

@NicolasDorier

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

I see, I will need to find another wordaround.

@NicolasDorier

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

will think about it after. I will be glad to see that merge already, I will rebase the other PR then.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

Reviewed, there is nothing strangeness or behavior modifying here. Merging.

@nopara73 nopara73 merged commit eaa622c into zkSNACKs:master Jun 19, 2019

3 of 4 checks passed

Wasabi.Windows #20190619.17 failed
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190619.17 succeeded
Details
Wasabi.Osx #20190619.17 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.