Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce whitespace under LegalIssues, PrivacyPolicy and TermsAndCondit… #1627

Merged
merged 2 commits into from Jun 26, 2019

Conversation

Projects
None yet
3 participants
@ravishwetha
Copy link
Contributor

commented Jun 26, 2019

…ions

For issue: #1496

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

It looks good on my Linux machine. Clearly the problem was fixed/improved in avalonia because this didn't work a year ago, I am sure. If this looks okay in Windows and Mac I am okay with this change.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

@lontivero Assuming this is ok, then we don't need the whitespaces at all, do we?

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

Without the 5 empty lines the end of the text is lost. I think there is something else here because at least in my machine the scrollbar doesn't display the bottom arrow.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

Yes, it's not working properly.

image

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

Anyway, I merge this and open an issue for the scroller.

@nopara73 nopara73 merged commit a396135 into zkSNACKs:master Jun 26, 2019

1 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Osx in progress
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.