Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #1648

Merged
merged 1 commit into from Jun 30, 2019

Conversation

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented Jun 28, 2019

This pull request is a part of breaking down the MempoolStore PR (#1609) into smaller, more reviewable parts.

@nopara73 nopara73 requested a review from lontivero Jun 28, 2019

@lontivero
Copy link
Collaborator

left a comment

It is okay but I don't see where the call to this method is removed. Anyway, I am sure the call was removed, otherwise it won't compile.

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 30, 2019

We don't call this anymore. We called this before when we cleaned the mempool with nodes not with the coordinator. I thought it's good to keep around, but this made the mempoolstore more difficult.

@nopara73 nopara73 merged commit da8410a into zkSNACKs:master Jun 30, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190628.11 succeeded
Details
Wasabi.Osx #20190628.11 succeeded
Details
Wasabi.Windows #20190628.11 succeeded
Details

@nopara73 nopara73 deleted the nopara73:unused branch Jun 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.