Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltip, changed title #1668

Merged

Conversation

Projects
None yet
3 participants
@varsnotwars
Copy link
Contributor

commented Jun 29, 2019

Closes: #1599

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2019

Both the tooltip and the "anonymity set target" is incorrect. These are levels. These only become targets when the user selects it in the coinjoin, so I guess "Anonymity Levels" would make more sense.

I don't know what the tooltip should be if there should be any.

@nopara73 nopara73 merged commit fec6110 into zkSNACKs:master Jun 30, 2019

1 of 4 checks passed

Wasabi.Linux queued
Details
Wasabi.Osx queued
Details
Wasabi.Windows queued
Details
CodeFactor No issues found.
Details
@varsnotwars

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

Ah, right. The tooltip and title change were what was written on the 'solution' part of the issue.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2019

Sure, it just wasn't discussed. @MaxHillebrand is a user, he wants faster horses :P

@varsnotwars

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

😅

@MaxHillebrand

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Yes to both, Anonymity Level makes more sense, it's only the target when selected.
And absolutely, give me the fastest horses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.