Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red coins should not be merged. #1669

Merged
merged 1 commit into from Jun 30, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -275,7 +275,8 @@ private IEnumerable<TxoRef> GetRegistrableCoinsNoLock(int maximumInputCountPerPe
int bestMinAnonset = bestSet.Min(x => x.AnonymitySet);
var bestSum = Money.Satoshis(bestSet.Sum(x => x.Amount));

if (!bestSum.Almost(amountNeeded, Money.Coins(0.0001m)))
if (!bestSum.Almost(amountNeeded, Money.Coins(0.0001m)) // Otherwise it wouldn't generate change so consolidation would make no sense.
&& bestMinAnonset > 1) // Red coins should never be merged.
{
IEnumerable<SmartCoin> coinsThoseCanBeConsolidated = coins
.Except(bestSet) // Get all the registrable coins, except the already chosen ones.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.