Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen Lock implementation #1681

Merged
merged 71 commits into from Jul 23, 2019

Conversation

@jmacato
Copy link
Collaborator

commented Jul 1, 2019

What does the pull request do?

Implements a multitude of screen locks (PIN and Slide-up) for added privacy.

Specifications:

#1614

Initial Implementation of Lock Screens.
Starting with Slide-up lock screen first.

@jmacato jmacato changed the title Screen Lock implementation [WIP] Screen Lock implementation Jul 1, 2019

jmacato added 2 commits Jul 2, 2019
@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

Scream if it's review ready.

@jmacato jmacato force-pushed the jmacato:lockscreen-impl branch from 2c4f818 to f1aa8c2 Jul 2, 2019

jmacato added 14 commits Jul 2, 2019
@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

Very interesting feature, I like it.
But there is this animation upwards when it says Drag and slide up to unlock. and this would be the only animated movement in Wasabi.
Not sure if it fits the entire design...

@jmacato

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 4, 2019

@MaxHillebrand Those animations are really a bit tacky right now honestly, but i believe that subtle animations gives an illusion (not in the bad sense) of responsiveness and snappiness so i think we can refine the concept here first then perhaps propagate that notion in the app.

jmacato added 4 commits Jul 6, 2019
@danwalmsley

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2019

@jmacato id like to have a chance to suggest a few changes before review, i'll try to get to it this evening.

nopara73 and others added 8 commits Jul 22, 2019
molnard and others added 2 commits Jul 23, 2019
nopara73 and others added 2 commits Jul 23, 2019
molnard added 2 commits Jul 23, 2019

@molnard molnard merged commit 0624a83 into zkSNACKs:master Jul 23, 2019

3 of 4 checks passed

Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190723.16 succeeded
Details
Wasabi.Osx #20190723.16 succeeded
Details

@jmacato jmacato deleted the jmacato:lockscreen-impl branch Jul 23, 2019

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2019

Oh fantastic work!!
Thanks all ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.