Refactor Log method #1684
Closed
Refactor Log method #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code is okay but I doesn't add much value IMO. Maybe, we could take the opportunity and remove all the encryption parts that we are not using. @nopara73? |
|
Didn't look at the code yet, but agree with @lontivero about removing the encryption part. |
nopara73
reviewed
Jul 1, 2019
| } | ||
|
|
||
| if (level < MinimumLevel) | ||
| if (Modes.Count == 0 || !IsOn() || level < MinimumLevel) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This change makes no sense.
There was a problem hiding this comment.
It simply groups the two if statements.
nopara73
reviewed
Jul 1, 2019
nopara73
reviewed
Jul 1, 2019
| else | ||
| { | ||
| File.AppendAllText(FilePath, finalFileMessage); | ||
| } | ||
| } |
There was a problem hiding this comment.
This does, but since we're removing encryption this won't either.
There was a problem hiding this comment.
I don't know about the encryption part. I simply changed the code to be easily readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.