Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nugtes #1686

Merged
merged 2 commits into from Jul 1, 2019

Conversation

Projects
None yet
2 participants
@nopara73
Copy link
Collaborator

commented Jul 1, 2019

Closes #1683
Closes #1678

nopara73 added some commits Jul 1, 2019

@@ -298,7 +298,7 @@ public void Synchronize()
for (int i = 0; i < tx.Outputs.Count; i++)
{
var output = tx.Outputs[i];
if (!output.ScriptPubKey.IsPayToScriptHash && output.ScriptPubKey.IsWitness)
if (output.ScriptPubKey.IsScriptType(ScriptType.P2WPKH))

This comment has been minimized.

Copy link
@nopara73

nopara73 Jul 1, 2019

Author Collaborator

I think this'll change the index, because it rules out P2WSH, which previously wasn't ruled out.

This comment has been minimized.

Copy link
@nopara73

nopara73 Jul 1, 2019

Author Collaborator

But at least the index file will be smaller, which is a huge bottle neck. Maybe we want to even rerun this on another computer, then put the new index to the server.

This comment has been minimized.

Copy link
@lontivero

lontivero Jul 1, 2019

Collaborator

I think this is a good change.
About reindexing, I think we are not going to save any space because if well I dodn't have real number on hands I think P2WSH are too rare.

This comment has been minimized.

Copy link
@lontivero

lontivero Jul 1, 2019

Collaborator

Here there are some revealing data: https://p2sh.info/dashboard/db/p2wsh-statistics?orgId=1

There are 340KB of P2WPKH UTXO hodling ~230000 BTCs against 62KB of P2WSH UTXO hodling 19000 BTCs. It seems they are not so rare as I thought but rare enough IMO. Anyway, the real important data for us is not the number of UTXOs but how frequently those utxos are destroyed (spent). Here the difference is bigger and then I think we can save some space but it will be very small.

@nopara73 nopara73 merged commit 2810f84 into zkSNACKs:master Jul 1, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190701.12 succeeded
Details
Wasabi.Osx #20190701.12 succeeded
Details
Wasabi.Windows #20190701.12 succeeded
Details

@nopara73 nopara73 deleted the nopara73:nugets branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.