Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to about page links #1692

Merged
merged 3 commits into from Jul 2, 2019

Conversation

Projects
None yet
5 participants
@benthecarman
Copy link
Contributor

commented Jul 1, 2019

I do not have an OSX computer, I'd appreciate if someone was able to test the functionality for it.

@lontivero
Copy link
Collaborator

left a comment

You have to address the onion domain issue and it would be good to remove the url duplication by having them all in the view model and bind the ExtendedTextBox::Text property to VM promerties.

@benthecarman benthecarman force-pushed the benthecarman:about_links branch from a3f3322 to 1cb08d1 Jul 1, 2019

@benthecarman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Reverted the tor link and bound the addresses to VM properties

@danwalmsley

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@nopara73 originally we didnt make these links clickable because we thought it might be a privacy issue, is this still the policy?

nopara73 added some commits Jul 2, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

@danwalmsley Yes, we're more practical since.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

I fixed up this PR. 2 main things. I use a single command instead of x commands.

I also use IoHelpers.BrowserOpen and removed your function, since this is tested.

@nopara73 nopara73 merged commit 01b7dad into zkSNACKs:master Jul 2, 2019

1 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Osx in progress
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
@molnard

molnard approved these changes Jul 2, 2019

@benthecarman benthecarman deleted the benthecarman:about_links branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.