Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Re-labeling RX Address #1693

Merged
merged 21 commits into from Jul 4, 2019

Conversation

Projects
None yet
3 participants
@danwalmsley
Copy link
Contributor

commented Jul 1, 2019

Draft because need to find a nice icon for the context menu, but functional.

Fixes #1433

@MaxHillebrand @nopara73

@MaxHillebrand

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Very nice, it works for me!
Right click is the intuitive choice, it works even when the address details is expanded.

However, I would change it from Re-Label to Change Label, this is more in line with Copy Address Copy Label.

[I've changed it locally, and am currently figuring out how to PR it...]

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

@MaxHillebrand Giving up? :)

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

(ACK for @MaxHillebrand's suggestion btw.)

nopara73 added some commits Jul 2, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

I wanted to fix it up, but too many things were off, so I stop here. My initial todo list for this:

  • put back lurking wife mode
  • something is off, it works strangely
  • icon
  • Re-label -> Change Label
@danwalmsley

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

  • put back lurking wife mode
  • something is off, it works strangely (iv paid close attention to detail to fix strange interaction problems and believe this works well now, let me know if you dont agree)
  • icon
  • Re-label -> Change Label

@danwalmsley danwalmsley marked this pull request as ready for review Jul 2, 2019

nopara73 added some commits Jul 3, 2019

LurkingWifeConverter: fix implementation of convertback.
Co-Authored-By: nopara73 <adam.ficsor73@gmail.com>
@MaxHillebrand
Copy link
Contributor

left a comment

Everything works fine, I like the name and icon.
Can this be moved out of Draft?

@danwalmsley

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Everything works fine, I like the name and icon.
Can this be moved out of Draft?

its no longer a draft, just needs @nopara73 to finally approve.

nopara73 added some commits Jul 4, 2019

@nopara73
Copy link
Collaborator

left a comment

UX

Perfect.

ToDo

  • put back lurking wife mode
  • something is off, it works strangely
  • icon
  • Re-label -> Change Label

Code

Cannot find many smells.

@nopara73 nopara73 merged commit 318c420 into zkSNACKs:master Jul 4, 2019

1 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Osx in progress
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.