Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fix for variable name #1694

Merged
merged 2 commits into from Jul 2, 2019

Conversation

Projects
None yet
2 participants
@benthecarman
Copy link
Contributor

commented Jul 1, 2019

BackenMajordVersion -> BackendMajorVersion

benthecarman and others added some commits Jul 1, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

This, if deployed would break existing clients, because they are expecting "BackenMajorVersion".

image

I added back the typo with a json property and explained in a comment why it's necessary.

@nopara73 nopara73 merged commit 64d7e31 into zkSNACKs:master Jul 2, 2019

1 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Osx in progress
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details

@benthecarman benthecarman deleted the benthecarman:var_spelling_fix branch Jul 2, 2019

@benthecarman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

If a non-backwards compatible change is ever made this should be fixed as well then

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 6, 2019

[JsonProperty(PropertyName = "BackenMajordVersion")] keeps the typo in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.