Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only generate QR code when needed #1695

Merged
merged 3 commits into from Jul 2, 2019

Conversation

Projects
None yet
4 participants
@benthecarman
Copy link
Contributor

commented Jul 1, 2019

Should be a small performance improvement

@benthecarman benthecarman force-pushed the benthecarman:qr_code_gen branch from a73ea4d to 0b39514 Jul 2, 2019

nopara73 added some commits Jul 2, 2019

@nopara73 nopara73 merged commit 29e7088 into zkSNACKs:master Jul 2, 2019

1 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Osx queued
Details
Wasabi.Windows queued
Details
CodeFactor No issues found.
Details
@MaxHillebrand

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

What does the user need to do in order to get the QR code then?
Is it an extra button / click, or automatically when the drop-down is activated?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

@MaxHillebrand Nothing changed in the UI, this just makes the UI more responsive.

@benthecarman benthecarman deleted the benthecarman:qr_code_gen branch Jul 2, 2019

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

Good PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.