Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle sensitive data on advanced wallet info #1712

Merged
merged 4 commits into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@benthecarman
Copy link
Contributor

commented Jul 3, 2019

Added the ability to hide the sensitive keys after unlocking them. Prior to this PR you would need to close the advanced wallet info tab and re open it for you to hide the keys

@benthecarman benthecarman force-pushed the benthecarman:toggle_wallet_info branch from 73c8589 to 7f9b4ce Jul 3, 2019

@MaxHillebrand

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

I checked out the branch, no errors, but I'm not sure what exactly you are doing here?
Can you please document your commit more thoroughly?

@MaxHillebrand
Copy link
Contributor

left a comment

Ah ok, now I get the feature!

After I type in the password and click Show Sensitive Keys, it switches the button to Hide Sensitive Keys which I can click without typing the password. If I want to see it again, then it needs the password.
There's also a 30 second automatic hiding, but I think that is out of the scope of this PR.

Very good, ACK.

nopara73 added some commits Jul 3, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

Pefect! It added zero UX clutter and the implementation is elegant.

@nopara73 nopara73 merged commit 6f4bf36 into zkSNACKs:master Jul 3, 2019

2 of 4 checks passed

Wasabi.Osx #20190703.29 failed
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190703.29 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:toggle_wallet_info branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.