Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No notification of ZeroLink coins #1780

Conversation

@lontivero
Copy link
Collaborator

commented Jul 5, 2019

People get confused when they see notifications saying they received xxx.yyyBTC after a successful coinjoin participation. This PR do not display those notifications when the received coin is a ZeroLink coin.

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2019

This closes #1685, although it might be good to show a different notification, Successful coin join round with XXX anon set. or something.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2019

Adding ZeroLink property to a SmartCoin smells.
Also the fact that it relies on the label smells. We are moving towards removing the labels.

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

What should I do?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

I think these notifications should go to the transaction history and fire up with the amount of the new transaction. Which I think requires the refactoring of the transaction history and it'd be good if we'd wait for Avalonia notifications, because starting processes in viewmodels just seems scary to me.

What should I do?

To sum up. I don't know, wait :/

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Yes, probably good to first update Avalonia, and then work on the new notification system...

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 2, 2019

@lontivero !x.hdpubkey.isinternal !!!

@lontivero lontivero force-pushed the lontivero:Features/Do-No-Display-Notification-For-ZeroLink branch from d63da40 to c76b821 Aug 2, 2019

@nopara73 nopara73 merged commit 382f1f7 into zkSNACKs:master Aug 2, 2019

3 of 4 checks passed

Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190802.14 succeeded
Details
Wasabi.Osx #20190802.14 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.