Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove S_ prefix for const (name violation rule) #1809

Merged
merged 1 commit into from Jul 7, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Jul 6, 2019

No description provided.

@MaxHillebrand
Copy link
Collaborator

left a comment

I'm not sure what the S_ stands for, thus not sure if we can remove it...

@danwalmsley

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2019

some codebases use s_ if its a static variable so s == static :)

This code was taken from another repository.

@nopara73 nopara73 merged commit 1c9d781 into zkSNACKs:master Jul 7, 2019

3 of 4 checks passed

Wasabi.Osx #20190706.41 failed
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190706.41 succeeded
Details
Wasabi.Windows #20190706.41 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:const-name branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.