Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BooleanStringConverter #1823

Merged
merged 4 commits into from Jul 7, 2019

Conversation

@nopara73
Copy link
Collaborator

commented Jul 7, 2019

Closes #1751

I cherry-picked @lontivero's first commits from here: #1751

The idea is to use the exact same BooleanStringConverter with the exact same pattern and to only add the desired values to the converter's parameter. So the xaml doesn't have to be aware what's in the code. Thus changes can be done at one place and don't have to touch 2 parts of the code to change, only one.

lontivero and others added 4 commits Jul 4, 2019

@nopara73 nopara73 marked this pull request as ready for review Jul 7, 2019

@nopara73 nopara73 requested a review from lontivero Jul 7, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

This should be good now. @lontivero have any questions, suggestions before merge?

@lontivero
Copy link
Collaborator

left a comment

No, no questions.

@nopara73 nopara73 merged commit 615bf27 into zkSNACKs:master Jul 7, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190707.23 succeeded
Details
Wasabi.Osx #20190707.23 succeeded
Details
Wasabi.Windows #20190707.23 succeeded
Details

@nopara73 nopara73 deleted the nopara73:booleanstringconverter branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.