Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display sensitive data in red color #1841

Merged
merged 2 commits into from Jul 8, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Jul 8, 2019

I think it is easier to distinguish the sensitive data when it is displayed in a different color.

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Although I like the idea of highlighting the private data, I would change the color scheme, it is barely readable now...
screenshot_20190708_094727

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

I agree. So what color do you suggest? IMO it should be something close to red to show that it is sensitive data.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Concept ACK. Also agree with @MaxHillebrand's suggestion. Maybe the color could be the same as to the color of the outgoing transaction amounts. How does IndianRed looks like there?

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

IndianRed looks better I think.

@nopara73 nopara73 merged commit f1560df into zkSNACKs:master Jul 8, 2019

2 of 4 checks passed

Wasabi.Osx #20190708.26 failed
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190708.26 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:red-sensitive-data branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.