Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DeepEquals for config file change detection #1850

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@nopara73
Copy link
Collaborator

commented Jul 8, 2019

I am planning to create a series of pull requests that is breaking down the following PRs and issues into small, reviewable parts.

#1739
#1740
#1738

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

@NicolasDorier You can review it, too. I think it's good.

@nopara73 nopara73 merged commit 6f3fb84 into zkSNACKs:master Jul 8, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190708.11 succeeded
Details
Wasabi.Osx #20190708.11 succeeded
Details
Wasabi.Windows #20190708.11 succeeded
Details

@nopara73 nopara73 deleted the nopara73:conf1 branch Jul 8, 2019

@NicolasDorier

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

-200 feel good man

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

@NicolasDorier I added this PR to your points:

In PR /pull/1850 nopara73 implemented @NicolasDorier's changes, so 17+217=234 points added to Nicolas's score.

https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Documentation/Guides/20190617ContributionGame.md

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

@NicolasDorier Would you like to continue the breakup of those PRs and issue?

@NicolasDorier

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

@nopara73 sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.