Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove unused code #1851

Merged
merged 4 commits into from Jul 9, 2019

Conversation

@NicolasDorier
Copy link
Collaborator

commented Jul 8, 2019

A bunch of unused boilerplate

@nopara73
Copy link
Collaborator

left a comment

I didn't know it's unused.

  • Anyhow could you make sure it's consistent with the rest of the config files, too? Config.cs in the Gui and in the Backend project, UiConfig and CcjRoundConfig
  • Run tests - @nopara73
  • Test behavior - @nopara73
@NicolasDorier

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

Nah, the Backend project is using it in the regtestsfixture

@NicolasDorier

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

oh actually no I can remove some other

@NicolasDorier NicolasDorier force-pushed the NicolasDorier:refactor/remove-dead-code branch from 0042281 to 10ed1f3 Jul 8, 2019

@NicolasDorier

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

Ok, I could remove the UiConfig one. The Cjj one is used in tests for now.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

I'd like to keep the pattern of Config files consistent across the codebase. Maybe make the setters public everywhere and use object initializer syntax instead of the constructor syntax?

@NicolasDorier

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

I removed the CcjRoundConfig constructor, it was used only in the tests.

nopara73 added 2 commits Jul 9, 2019

@nopara73 nopara73 merged commit 7ba8be3 into zkSNACKs:master Jul 9, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190709.22 succeeded
Details
Wasabi.Osx #20190709.22 succeeded
Details
Wasabi.Windows #20190709.22 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.