Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary OSPlatform check #1860

Merged
merged 3 commits into from Jul 18, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Jul 9, 2019

No description provided.

@yahiheb yahiheb referenced this pull request Jul 9, 2019
@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

NACK this. I've explained the reasoning in the big PR that has been broken up to. Actually I cannot dig that up.

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 10, 2019

I edited the code and I kept the immediate correction of fullBaseDirectory.

@molnard

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

That is fine, less checks easier to read.

@nopara73 nopara73 merged commit c78e1e1 into zkSNACKs:master Jul 18, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190710.2 succeeded
Details
Wasabi.Osx #20190710.2 succeeded
Details
Wasabi.Windows #20190710.2 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:tor-processmanager branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.