Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos, capitalization, punctuation #1869

Merged
merged 4 commits into from Jul 14, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Jul 10, 2019

No description provided.

@MaxHillebrand
Copy link
Collaborator

left a comment

All spelling / grammar / abbreviation corrections.
ACK.

@yahiheb, thanks for the contribution, yet could you please add a comment to your commits that summarizes the changes you've made? This will help with review by others, thanks :)

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 10, 2019

@MaxHillebrand I will try to do better next time, thank you.

@raindogdance

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Good catches!

There are a lot of changes from "there's" to "there is", "won't" -> "will not", "doesn't" -> "does not". I'm wondering what the rationale is, since both versions are grammatically correct? Some of the changes in the PR are inconsistent with all the other changes (exampe: "let's start with the launcher")

Otherwise ACK (except one error, see https://github.com/zkSNACKs/WalletWasabi/pull/1869/files#r302469518)

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2019

@raindogdance, there are many inconsistencies weather or not to use the 've 's 're etc... and @yahiheb has made an effort to bring in the consistency of always writing out these forms.

@MaxHillebrand
Copy link
Collaborator

left a comment

happened to has occurred [please fix the missing r]
's to us

ACK.

WalletWasabi.Backend/README.md Outdated Show resolved Hide resolved
@MaxHillebrand
Copy link
Collaborator

left a comment

Now all good :)
ACK

@nopara73 nopara73 merged commit 6c050ed into zkSNACKs:master Jul 14, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190711.17 succeeded
Details
Wasabi.Osx #20190711.17 succeeded
Details
Wasabi.Windows #20190711.17 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:typos branch Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.