Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos, capitalization, punctuation #1869

Merged
merged 4 commits into from Jul 14, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -2,9 +2,9 @@

## CodeMaid

**DO** use [CodeMaid](http://www.codemaid.net/) is a Visual Studio extension to automatically clean up your code on saving the file.
**DO** use [CodeMaid](http://www.codemaid.net/), a Visual Studio extension to automatically clean up your code on saving the file.

CodeMaid is a non-intrusive code cleanup tool. Wasabi's CodeMaid settings [can be found in the root of the repository](https://github.com/zkSNACKs/WalletWasabi/blob/master/CodeMaid.config), and are automatically picked up by Visual Studio when you open the project. Assuming the CodeMaid extension is installed. Unfortunately CodeMaid has no Visual Studio Code extension yet. You can check out the progress on this [under this GitHub issue](https://github.com/codecadwallader/codemaid/issues/273).
CodeMaid is a non-intrusive code cleanup tool. Wasabi's CodeMaid settings [can be found in the root of the repository](https://github.com/zkSNACKs/WalletWasabi/blob/master/CodeMaid.config), and are automatically picked up by Visual Studio when you open the project, assuming the CodeMaid extension is installed. Unfortunately CodeMaid has no Visual Studio Code extension yet. You can check out the progress on this [under this GitHub issue](https://github.com/codecadwallader/codemaid/issues/273).

## Comments

@@ -49,7 +49,7 @@ using (AsyncLock.Lock())
## Null Check
**DO** use `is null` instead of `== null`. It was a performance consideration in the past but from C# 7.0 it does not matter anymore, today we use this convention to keep our code consisent.
**DO** use `is null` instead of `== null`. It was a performance consideration in the past but from C# 7.0 it does not matter anymore, today we use this convention to keep our code consistent.
```cs
if (foo is null) return;
@@ -27,7 +27,7 @@

#### POST filters

At initial synchronization the wallet must specify the hash of the first block that contains native segwit output. This hash must be hard coded into the client.
At the initial synchronization the wallet must specify the hash of the first block that contains native segwit output. This hash must be hard coded into the client.
- First block with P2WPKH: dfcec48bb8491856c353306ab5febeb7e99e4d783eedf3de98f3ee0812b92bad
- First block with P2WPKH on TestNet: b29fbe96bf737000f8e3536e9b4681a01b1ca6be3ac4bd1f8269cdbd465e6700

@@ -36,7 +36,7 @@

#### Handling Reorgs

If the answer to the `filters` request is not found, then the client steps back one block and queries the filters with that previous hash. This can happen multiple times. This will only happen when blockchain reorganization happened.
If the answer to the `filters` request is not found, then the client steps back one block and queries the filters with that previous hash. This can happen multiple times. This will only happen when blockchain reorganization has occurred.

### Controller: ChaumianCoinJoin, Coin: BTC

@@ -66,7 +66,7 @@ ufw enable
> As the firewall is currently blocking all connections except for SSH, if you install and configure additional services, you will need to adjust the firewall settings to allow acceptable traffic in. You can learn some common UFW operations in this guide.
> https://www.digitalocean.com/community/tutorials/ufw-essentials-common-firewall-rules-and-commands
## Enabling External Access for User
## Enable External Access for User

```sh
rsync --archive --chown=user:user ~/.ssh /home/user
@@ -245,7 +245,7 @@ sudo ufw allow https
sudo apt-get install nginx -y
sudo service nginx start
```
Verify a browser displays the default landing page for Nginx. The landing page is reachable at `http://<server_IP_address>/index.nginx-debian.html`.
Verify the browser displays the default landing page for Nginx. The landing page is reachable at `http://<server_IP_address>/index.nginx-debian.html`.

```sh
sudo pico /etc/nginx/sites-available/default
@@ -271,13 +271,13 @@ sudo nginx -t
sudo nginx -s reload
```

Setup https, redirect to https when asks. This'll modify the above config file, but oh well.
Setup https, redirect to https when asks. This will modify the above config file, but oh well.

```sh
sudo certbot -d wasabiwallet.io -d www.wasabiwallet.io -d wasabiwallet.net -d www.wasabiwallet.net -d wasabiwallet.org -d www.wasabiwallet.org -d wasabiwallet.info -d www.wasabiwallet.info -d wasabiwallet.co -d www.wasabiwallet.co -d zerolink.info -d www.zerolink.info -d hiddenwallet.org -d www.hiddenwallet.org
```

certbot won't properly redirect www, so it must be setup by hand, one by one. Duplicate all entries like this by adding a `www.`:
certbot will not properly redirect www, so it must be setup by hand, one by one. Duplicate all entries like this by adding a `www.`:
```
server {
if ($host = wasabiwallet.co) {
@@ -1,6 +1,6 @@
# Code coverage (How to)

Wasabi wallet is built using dotnet core. Given there is no cross-platform Profiling API like the one available on Windows, we
Wasabi Wallet is built using dotnet core. Given there is no cross-platform Profiling API like the one available on Windows, we
use [AltCover](https://github.com/SteveGilham/altcover) package for instrumenting the assemblies and recording the execution
coverage.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.