Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Safe) Cleanup of SendTabViewModel #1872

Merged
merged 9 commits into from Jul 10, 2019

Conversation

@nopara73
Copy link
Collaborator

commented Jul 10, 2019

@benthecarman has created this PR #1857
closes #1857 (cherry picked @benthecarman's solution.)

Here I've been trying to refactor a couple of things to make sure the code doesn't rot. It still does, but at least I leave the code better than I found it. Anyhow, I started refactoring the SendTabViewModel under Ben's PR, but I am afraid I may have made some mistakes there, so I cherry-picked the safest cleanups and so this PR is born.

benthecarman and others added 9 commits Jul 8, 2019

@nopara73 nopara73 merged commit 3969a5a into zkSNACKs:master Jul 10, 2019

1 of 4 checks passed

Wasabi.Linux in progress
Details
Wasabi.Osx in progress
Details
Wasabi.Windows in progress
Details
CodeFactor No issues found.
Details

@nopara73 nopara73 deleted the nopara73:stw branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.