Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fee slider when unavailable #1880

Merged
merged 3 commits into from Jul 11, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Jul 10, 2019

Often on testnet (and hopefully mainnet) fees are so low that both the max and min targets are 2 blocks, when this happens then the fee slider on the send tab will not be usable. This PR removes the slider when this occurs and replaces it with a message.

Screenshot_2

Fixes #1492

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2019

Yes, awesome!
This actually fixes #1492!
Concept ACK, for sure :)

I like the idea of a funny message here, but do we have another icon? I don't think that smiley fit's the theme... maybe one of these green icons we have elsewhere?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2019

nopara73 added 2 commits Jul 11, 2019

@nopara73 nopara73 merged commit 7b227cb into zkSNACKs:master Jul 11, 2019

@benthecarman benthecarman deleted the benthecarman:super_low_fees branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.