Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linux dock issue #1899

Merged
merged 1 commit into from Jul 14, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Jul 12, 2019

Fixes: #1239

I cannot test this without creating a release and installing it (I don't know how to do that), but I believe this will fix the issue.

@nopara73 nopara73 requested review from danwalmsley and jmacato Jul 13, 2019

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2019

@danwalmsley @jmacato Can one of you take a look at this?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2019

@MaxHillebrand How were you able to test it? I think it needs a deb package release for that.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2019

Btw @benthecarman thanks a lot for this, it was super annoying and I didn't even had an idea where to start.

@jmacato

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2019

@nopara73 i can't replicate the bug on Cinnamon Desktop with our latest .deb package (1.1.6); I'll install a Ubuntu 18.04 with Gnome VM and test this one out in a bit

@jmacato
Copy link
Collaborator

left a comment

image
Confirmed fixed :) but we need to add StartupWMClass on our desktop file once we publish a deb

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 13, 2019

we need to add StartupWMClass on our desktop file once we publish a deb

Is that something I need to add to this PR?

@jmacato

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2019

@benthecarman I'd assume nothing else since i can't find any references on the codebase on how it packages the deb.

Sorry, please add the StartupWMClass on Line 818 of Program.cs at WalletWasabi.Packager project.

@benthecarman benthecarman force-pushed the benthecarman:fix_linux_dock_issue branch from 1148a9b to 5fb6dd6 Jul 13, 2019

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 13, 2019

@jmacato Should be good now

@nopara73 nopara73 merged commit b8da59e into zkSNACKs:master Jul 14, 2019

3 of 4 checks passed

Wasabi.Osx #20190713.28 failed
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190713.28 succeeded
Details
Wasabi.Windows #20190713.27 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:fix_linux_dock_issue branch Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.