Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corret some typos #1909

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Jul 15, 2019

Note that the comment inside SetTor() method in the StatusBarViewModel.cs file says: // Set peers to 0 if Tor is ... it should be modified I think.

@MaxHillebrand
Copy link
Collaborator

left a comment

ignoreable to ignorable
it's seem to it seems
equals to equal
equals to are equal
its to it is
public class WindowStateAfterSartJsonConverter to WindowStateAfterStartJsonConverter -> not sure if used elsewhere
internal static class PositioninngPatternBuilder to PositioningPatternBuilder

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

public class WindowStateAfterSartJsonConverter to WindowStateAfterStartJsonConverter -> not sure if used elsewhere

It's not. Checked.

@nopara73 nopara73 merged commit 22a93b5 into zkSNACKs:master Jul 15, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190715.1 succeeded
Details
Wasabi.Osx #20190715.1 succeeded
Details
Wasabi.Windows #20190715.1 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:typos branch Jul 15, 2019

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 15, 2019

Note that the comment inside SetTor() method in the StatusBarViewModel.cs file says: // Set peers to 0 if Tor is ... it should be modified I think.

@nopara73 did you see this?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

@yahiheb No I missed that, but just saw it now: #2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.