Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shuffle on coin join inputs and outputs #1927

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Jul 16, 2019

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 16, 2019

@NicolasDorier is this the correct way to do this?

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

The shuffle should be the latest step before signing so, it should goes after TryOptimizeFeesAsync.

@benthecarman benthecarman force-pushed the benthecarman:shuffle_cj branch from 8c1395d to 43af089 Jul 16, 2019

@NicolasDorier

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

I don't understand why changing this, the old 7. should have fixed it already.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

@NicolasDorier The old shuffled before the inputs were added to the transaction :)

@benthecarman yes, it's correct.

Additional note, ordering inputs by amounts after shuffling could be nice, too.

@nopara73 nopara73 merged commit 24bc0e6 into zkSNACKs:master Jul 17, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190716.28 succeeded
Details
Wasabi.Osx #20190716.28 succeeded
Details
Wasabi.Windows #20190716.28 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:shuffle_cj branch Jul 17, 2019

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 17, 2019

ordering inputs by amounts after shuffling could be nice, too.

I attempted to do this but I couldn't find how to get the input's value

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2019

@benthecarman inputs have no value. However, those inputs are the Alices' coins (they have a Value property) so, you could have a mapping <input, value>, sort it by value and re-order the inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.