Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort inputs by amount in CoinJoin #1944

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Jul 18, 2019

Thanks @lontivero for telling me how to do this correctly

@benthecarman benthecarman force-pushed the benthecarman:sort_inputs branch from fc11999 to c330550 Jul 18, 2019

@lontivero
Copy link
Collaborator

left a comment

Could you modify/update a test to verify the inputs are sorted?

@benthecarman benthecarman force-pushed the benthecarman:sort_inputs branch from c330550 to 8d6ceb8 Jul 18, 2019

@lontivero
Copy link
Collaborator

left a comment

@benthecarman, review the SortByAmout extension method and try to simplify it, please.

@benthecarman benthecarman force-pushed the benthecarman:sort_inputs branch from e84dfe4 to 8e896e3 Jul 18, 2019

@benthecarman benthecarman force-pushed the benthecarman:sort_inputs branch from 8e896e3 to edc2571 Jul 18, 2019

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2019

This PR looks good to me. I don't approve it yet because I need to review it better. I need to be sure we don't assume any order.

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 18, 2019

Thanks for the review! Learned a lot more than I expected from this PR

@lontivero
Copy link
Collaborator

left a comment

It is okay. We don't assume any order in the inputs.

@nopara73
Copy link
Collaborator

left a comment

This is very clean solution. Thank you for this!

@nopara73 nopara73 merged commit 2ce2ebb into zkSNACKs:master Jul 21, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190718.25 succeeded
Details
Wasabi.Osx #20190718.25 succeeded
Details
Wasabi.Windows #20190718.25 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:sort_inputs branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.