Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Private/Non-Private checkboxes use Target Privacy instead of Privacy Level Strong #1948

Merged

Conversation

@benthecarman
Copy link
Collaborator

commented Jul 18, 2019

Closes #1371

@MaxHillebrand
Copy link
Collaborator

left a comment

Tested on Debian 9, works!
ACK

@nopara73
Copy link
Collaborator

left a comment

Code LGTM, I'm not sure about the those -> that change, but I'm not a native English speaker, so who am I to argue?:)

@nopara73 nopara73 merged commit c98e1fa into zkSNACKs:master Jul 19, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190718.28 succeeded
Details
Wasabi.Osx #20190718.28 succeeded
Details
Wasabi.Windows #20190718.28 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:select_private_uses_mix_until branch Jul 19, 2019

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 19, 2019

Those is generally used as a subject or object, not a modifier

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Yeah, no clue what that means @benthecarman, haha, but it sounds fancy!

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 19, 2019

Lol some bs they taught me in English class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.