Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove execution permissions #1963

Merged
merged 8 commits into from Jul 30, 2019

Conversation

@lontivero
Copy link
Collaborator

commented Jul 20, 2019

This PR removes the execution permission to all files except for wassabee. I've refactored it just a bit to make the change easier to review.

lontivero and others added 2 commits Jul 20, 2019
@nopara73
Copy link
Collaborator

left a comment

Before I test it, can you make sure the permissions are consistent in the .tar.gz? Our InstallInstructions says to "extract it, while keeping the file permissions: tar -pxzf WasabiLinux-1.1.6.tar.gz".

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 24, 2019

Sure. .tar.gz file still contains files with wrong permissions.

@lontivero lontivero force-pushed the lontivero:Features/Fix-Linux-Permissions branch from 07144c2 to 6d75d1c Jul 25, 2019

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 25, 2019

Done.

@molnard
Copy link
Collaborator

left a comment

Don't know if it is relevant or not. I had to enter my password two times, and after I get this: packager quits.

"Could not find file 'C:\\work\\WalletWasabi\\WalletWasabi.Gui\\bin\\dist\\wassabee_1.1.6_amd64.deb'."

System.IO.FileNotFoundException
  HResult=0x80070002
  Message=Could not find file 'C:\work\WalletWasabi\WalletWasabi.Gui\bin\dist\wassabee_1.1.6_amd64.deb'.
  Source=System.IO.FileSystem
  StackTrace:
   at System.IO.File.Move(String sourceFileName, String destFileName)
   at WalletWasabi.Packager.Program.Publish() in C:\work\WalletWasabi\WalletWasabi.Packager\Program.cs:line 879

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 26, 2019

I left my own env path in the code. @molnard remember this code will not work for you in your path 'work', it uses the @nopara73 path /Users/user and that path is (and was) hardcoded. I can improve that but I would do it in a different PR. I wan to keep the PR as simple as possible.

You will need to enter the password twice because there are two different bash sessions, one for creating the tar.gz file and the other for creating the deb file. It is possible to do both in only one session but that change is bigger and could be rejected. I can do it in a different PR.

@nopara73 nopara73 self-requested a review Jul 28, 2019

@nopara73
Copy link
Collaborator

left a comment

One more thing: are OSX permissions correct?

WalletWasabi.Packager/Program.cs Show resolved Hide resolved
@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 28, 2019

One more thing: are OSX permissions correct?

I don't know. I have no way to verify it because I don't have the OSX VM anymore.

@molnard

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

Want me to jump in with some OSX tests?

@lontivero

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 30, 2019

Yes please @molnard.

@nopara73 nopara73 merged commit 2d5c36f into zkSNACKs:master Jul 30, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190730.17 succeeded
Details
Wasabi.Osx #20190730.17 succeeded
Details
Wasabi.Windows #20190730.17 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.