Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use (string == ) instead of (string.Length == 0) #1969

Merged
merged 1 commit into from Jul 20, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Jul 20, 2019

No description provided.

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Jul 20, 2019

Is this comparison faster?

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 20, 2019

It is not I think, according to this. The reason I edited it is because we used == "" elsewhere, maybe we should use .Length == 0 or IsNullOrEmpty method according to the same link.

@nopara73
Copy link
Collaborator

left a comment

ACK. string.Length == 0 is really strange.

@nopara73 nopara73 merged commit a9b614a into zkSNACKs:master Jul 20, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190720.9 succeeded
Details
Wasabi.Osx #20190720.9 succeeded
Details
Wasabi.Windows #20190720.9 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:string-length branch Jul 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.