Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format files #1972

Merged
merged 3 commits into from Jul 28, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Jul 20, 2019

Remove java like brackets & correct indentation & wrap arguments & remove extra comma.

yahiheb added 2 commits Jul 20, 2019
WalletWasabi.Gui/Controls/EditableTextBlock.cs Outdated Show resolved Hide resolved
WalletWasabi.Gui/Controls/EditableTextBlock.cs Outdated Show resolved Hide resolved
WalletWasabi.Gui/Global.cs Outdated Show resolved Hide resolved
WalletWasabi.Gui/Shell/Commands/HelpCommands.cs Outdated Show resolved Hide resolved
WalletWasabi.Tests/ModelTests.cs Outdated Show resolved Hide resolved
@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 27, 2019

@molnard I put back the brackets in different lines. Should this be done in the entire code base?

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 28, 2019

While I disagree with some of the things here, overall the code is better than it was and I don't want to nitpick much, because these are safe changes, because these are whitespace only changes, so I'm merging this.

@nopara73 nopara73 merged commit 0a1a2a5 into zkSNACKs:master Jul 28, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190727.21 succeeded
Details
Wasabi.Osx #20190727.22 succeeded
Details
Wasabi.Windows #20190727.21 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:format-files branch Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.