Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Warning In Wallet Info Tab #1974

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Jul 20, 2019

Fixes #1971

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 21, 2019

Concept ACK - does anyone know a better warning message, or is this one good enough?
Tested on Debian 9 - works!

@nopara73
Copy link
Collaborator

left a comment

Concept NACK. It's very very chatty and this is common sense for the target audience of the "Advanced" tab, which are the "advanced users."

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 21, 2019

I agree, this is chatty.
Maybe better to have only:

Anyone with the extended public key can de-anonymize all your coins. 
Anyone with the extended private key can spend all your coins. 
Do not share this with anyone you do not trust.

I still concept ACK, because this is a huge risk of loss of privacy [even more than coin consolidation, which has a warning], and even advanced users should be reminded. This is similar to the warning message the ColdCard provides when exporting Wasabi Wallet skeleton file.

It might arguably be better / more pretty to have this warning in a tooltip, not in the main GUI.

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 21, 2019

Is Wasabi using hardened keys?

As Bill points out, if not, then we could mention that non-hardened xpub + single private key leads to complete loss of funds.

@benthecarman benthecarman force-pushed the benthecarman:privacy_warning_wallet_info branch from cfdf9a8 to 4c0dce6 Jul 21, 2019

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 21, 2019

Moved to tool tip

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

Tested on Debian.

The tooltip does not wrap lines, and it can slip over the ride side of the wallet, cutting of the last part of the sentence.

Right now there's both the main GUI text, as well as the tooltip. We need only one.

I think the tooltip is better - less GUI clutter - but the message still comes across.

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2019

You might be pulling it wrong because I removed the text at the bottom. I will try and fix the text wrapping.

@nopara73 nopara73 merged commit ef29d48 into zkSNACKs:master Jul 22, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190722.4 succeeded
Details
Wasabi.Osx #20190722.4 succeeded
Details
Wasabi.Windows #20190722.4 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:privacy_warning_wallet_info branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.