Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed Open File/Folder Dialog compatible with all Linux Distros #1993

Merged
merged 48 commits into from Jul 25, 2019

Conversation

@danwalmsley
Copy link
Collaborator

commented Jul 23, 2019

image

@danwalmsley danwalmsley changed the title WIP: Feature/managed file dialogs Managed Open File/Folder Dialog compatible with all Linux Distros Jul 24, 2019

@danwalmsley danwalmsley marked this pull request as ready for review Jul 24, 2019

danwalmsley added 3 commits Jul 24, 2019
@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

This is really cool - Concept ACK - I tested already on Debian 9, maybe a bit too early, but I got excited...

It works very well in the Hardware Wallet tab. The file system, all the buttons, and the window gui etc seem to all be in order. I especially like the logo in the upper corner and the overall fitting theme!

And just FYI, as of 428578c, there is still the old file system in the Wallet Manager tab.

danwalmsley added 3 commits Jul 24, 2019
@danwalmsley

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 24, 2019

Added changes to make it compatible with save file dialog and also look / work better on osx.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

It cuts the files' name.

image


IMO the cursor shouldn't be a 'hand' but and 'arrow'. It feels wrong when you have to do double-click and the cursor is a hand.

It looks and behaves well. I didn't test it much but I couldn't make it fail.

@danwalmsley

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 24, 2019

I also fixed the Hand cursor @lontivero

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

Yes - with the c532d3c it no longer crashes when no file name is given.
Seems to work now, I'll continue the testing though.

danwalmsley added 2 commits Jul 24, 2019
@danwalmsley

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 24, 2019

@nopara73 good feedback from -> @MaxHillebrand @lontivero

All the issues they have raised are fixed.

Iv tested:

OpenFileDialog,
OpenFolderDialog
SaveFileDialog.

Seems stable, we added it to list the drives on osx and linux, and save file handles the extension correctly too.

@MaxHillebrand
Copy link
Collaborator

left a comment

I've now done several full walk-throughs, and it seems to work without any issues.
[Oh, I did not test the skeleton wallet import.]

I like the new design, all the functions are working, txid as file name is good, .psbt ending by default.

Seems everything is in order!

ACK

@jmacato
Copy link
Collaborator

left a comment

Works Great :)
System: Ubuntu 18.04 LTS

@nopara73 nopara73 merged commit 274023e into zkSNACKs:master Jul 25, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190724.52 succeeded
Details
Wasabi.Osx #20190724.52 succeeded
Details
Wasabi.Windows #20190724.52 succeeded
Details

@danwalmsley danwalmsley deleted the danwalmsley:feature/managed-file-dialogs branch Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.